Update AuditConfig.DEPRECATED_KEYS deprecation message to match 4.0 #5155
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
shikharj05
requested review from
cwperks,
DarshitChanpura,
derek-ho,
nibix,
peternied,
RyanL1997,
reta and
willyborankin
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5155 +/- ##
==========================================
+ Coverage 71.67% 71.69% +0.02%
==========================================
Files 337 337
Lines 22783 22783
Branches 3604 3604
==========================================
+ Hits 16329 16335 +6
+ Misses 4653 4648 -5
+ Partials 1801 1800 -1
🚀 New features to boost your workflow:
|
DarshitChanpura
approved these changes
Mar 8, 2025
kumjiten
approved these changes
Mar 10, 2025
willyborankin
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the deprecation message to mark removal in 4.0. This aligns with removal of all legacy terms in 4.0- #5092
Required by Remove deprecated settings from code #4117 & Deprecate legacy language from the security plugin repo in 3.0.0 for removal in 4.0.0 #5092
Issues Resolved
#4117
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failedlabel from the original PR.Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.